709406 - Change location of slow SQL statements in Telemetry JSON object

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Vladan Djeric (:vladan)]

(7:33:03 PM) taras: in retrospect Telemetry.histogramSnapshots; should not contain sql stuff
(7:33:09 PM) taras: that should be on toplevel Telemetry object
(7:33:11 PM) taras: :(
(7:33:39 PM) taras: yeah i think we should change that

Comment 1

[Vladan Djeric (:vladan)]

Attachment: Move slow SQL in JSON + report it in ping + add regression tests

Comment 2

[Vladan Djeric (:vladan)]

Attachment: Update about:telemetry extension to work with old and new slow SQL formats

Comment 3

[Vladan Djeric (:vladan)]

Note that about:telemetry has an existing bug where an exception is thrown when the extension is upgraded or disabled then enabled, which requires Firefox to be restarted after a new version is installed. Unless I'm missing some info, the fix should be as simple as calling unregisterFactory in the shutdown and uninstall methods..

Comment 4

[Vladan Djeric (:vladan)]

Attachment: Move slow SQL in JSON + report it in ping + add regression tests

Removed an unused variable

Comment 5

[(dormant account)]

Comment on attachment 581295 [details] [diff] [review]
Move slow SQL in JSON + report it in ping + add regression tests

s/slowSQLData/slowSQL/

Comment 6

[Mozilla RelEng Bot]

Try run for a14bf290dfda is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=a14bf290dfda
Results (out of 139 total builds):
    exception: 38
    success: 37
    warnings: 4
    failure: 60
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-a14bf290dfda

Comment 7

[(dormant account)]

Comment on attachment 581076 [details] [diff] [review]
Update about:telemetry extension to work with old and new slow SQL formats

lets hold off on this review until the api settles

Comment 8

[Vladan Djeric (:vladan)]

Attachment: Move slow SQL in JSON + report it in ping + add regression tests, v3

Changed format in which slow SQL statements are reported.

Note that the build failures above are the result of a cancelled build.

Comment 9

[Vladan Djeric (:vladan)]

Attachment: Move slow SQL in JSON + report it in ping + add regression tests, v3

Changed format in which slow SQL statements are reported.

Note that the build failures above are the result of a cancelled build.

Comment 10

[Vladan Djeric (:vladan)]

Attachment: Update about:telemetry extension to work with old and new slow SQL formats, v2

Updated to work with new API

Comment 11

[Vladan Djeric (:vladan)]

Attachment: Move slow SQL in JSON + report it in ping + add regression tests, v3 (checkin ready)

Added name to contributors list per Taras's suggestion. Ready for checkin, got review+ on previous version (with identical code)

Comment 12

[(dormant account)]

Comment on attachment 581446 [details] [diff] [review]
Update about:telemetry extension to work with old and new slow SQL formats, v2

I don't think we should have backward compat for a one-time API blip.

Comment 13

[Vladan Djeric (:vladan)]

Attachment: Update about:telemetry extension to work with new slow SQL format, v3

Removed backwards-compatibility as requested

Comment 14

[(dormant account)]

Comment on attachment 581459 [details] [diff] [review]
Update about:telemetry extension to work with new slow SQL format, v3

I'll check in addon changes once mozilla-central change lands

Comment 15

[Mozilla RelEng Bot]

Try run for 89254bd869e1 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=89254bd869e1
Results (out of 208 total builds):
    success: 182
    warnings: 24
    failure: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-89254bd869e1

Comment 16

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

https://hg.mozilla.org/mozilla-central/rev/99dedca7064e

Just noticed I forgot to change the author line :-(
Sorry about that.

Comment 17

[Mozilla RelEng Bot]

Try run for a14bf290dfda is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=a14bf290dfda
Results (out of 139 total builds):
    exception: 38
    success: 37
    warnings: 4
    failure: 60
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-a14bf290dfda

Comment 18

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Backed out of Aurora.

https://hg.mozilla.org/releases/mozilla-aurora/rev/fd0cc7723a3c